"Fossies" - the Fresh Open Source Software Archive

Member "electron-4.2.12/docs/development/upgrading-node.md" (16 Oct 2019, 5442 Bytes) of package /linux/www/electron-4.2.12.tar.gz:


As a special service "Fossies" has tried to format the requested source page into HTML format (assuming markdown format). Alternatively you can here view or download the uninterpreted source code file. A member file download can also be achieved by clicking within a package contents listing on the according byte size field.

Upgrading Node

Discussion

Chromium and Node.js both depend on V8, and Electron contains only a single copy of V8, so it’s important to ensure that the version of V8 chosen is compatible with the build’s version of Node.js and Chromium.

Upgrading Node is much easier than upgrading Chromium, so fewer conflicts arise if one upgrades Chromium first, then chooses the upstream Node release whose version of V8 is closest to the one Chromium contains.

Electron has its own Node fork with modifications for the V8 build details mentioned above and for exposing API needed by Electron. Once an upstream Node release is chosen, it’s placed in a branch in Electron’s Node fork and any Electron Node patches are applied there.

Another factor is that the Node project patches its version of V8. As mentioned above, Electron builds everything with a single copy of V8, so Node’s V8 patches must be ported to that copy.

Once all of Electron’s dependencies are building and using the same copy of V8, the next step is to fix any Electron code issues caused by the Node upgrade.

[FIXME] something about a Node debugger in Atom that we (e.g. deepak) use and need to confirm doesn’t break with the Node upgrade?

So in short, the primary steps are:

  1. Update Electron’s Node fork to the desired version
  2. Backport Node’s V8 patches to our copy of V8
  3. Update the GN build files, porting changes from node’s GYP files
  4. Update Electron’s DEPS to use new version of Node

Updating Electron’s Node fork

  1. Ensure that master on electron/node has updated release tags from nodejs/node
  2. Create a branch in https://github.com/electron/node: electron-node-vX.X.X where the base that you’re branching from is the tag for the desired update
  1. Re-apply our commits from the previous version of Node we were using (vY.Y.Y) to v.X.X.X

Updating V8 Patches

We need to generate a patch file from each patch that Node applies to V8.

$ cd third_party/electron_node
$ CURRENT_NODE_VERSION=vX.Y.Z
# Find the last commit with the message "deps: update V8 to <some version>"
# This commit corresponds to Node resetting V8 to its pristine upstream
# state at the stated version.
$ LAST_V8_UPDATE="$(git log --grep='^deps: update V8' --format='%H' -1 deps/v8)"
# This creates a patch file containing all changes in deps/v8 from
# $LAST_V8_UPDATE up to the current Node version, formatted in a way that
# it will apply cleanly to the V8 repository (i.e. with `deps/v8`
# stripped off the path and excluding the v8/gypfiles directory, which
# isn't present in V8.
$ git format-patch \
    --relative=deps/v8 \
    $LAST_V8_UPDATE..$CURRENT_NODE_VERSION \
    deps/v8 \
    ':(exclude)deps/v8/gypfiles' \
    --stdout \
    > ../../electron/common/patches/v8/node_v8_patches.patch

This list of patches will probably include one that claims to make the V8 API backwards-compatible with a previous version of V8. Unfortunately, those patches almost always change the V8 API in a way that is incompatible with Chromium.

It’s usually easier to update Node to work without the compatibility patch than to update Chromium to work with the compatibility patch, so it’s recommended to revert the compatibility patch and fix any errors that arise when compiling Node.

Update Electron’s DEPS file

Update the DEPS file in the root of electron/electron to point to the git hash of the updated Node.

Notes