"Fossies" - the Fresh Open Source Software Archive  

Source code changes of the file "CONTRIBUTING" between
tcpdump-4.99.0.tar.gz and tcpdump-4.99.1.tar.gz

About: tcpdump is a tool for network monitoring and data acquisition.

CONTRIBUTING  (tcpdump-4.99.0):CONTRIBUTING  (tcpdump-4.99.1)
skipping to change at line 46 skipping to change at line 46
How to add new code and to update existing code How to add new code and to update existing code
----------------------------------------------- -----------------------------------------------
0) Check that there isn't a pull request already opened for the changes you 0) Check that there isn't a pull request already opened for the changes you
intend to make. intend to make.
1) Fork the Tcpdump repository on GitHub from 1) Fork the Tcpdump repository on GitHub from
https://github.com/the-tcpdump-group/tcpdump https://github.com/the-tcpdump-group/tcpdump
(See https://help.github.com/articles/fork-a-repo/) (See https://help.github.com/articles/fork-a-repo/)
2) Setup optional continuous integration (CI) builds 2) The easiest way to test your changes on multiple operating systems and
You can setup Travis CI, Cirrus CI and AppVeyor builds for your fork to architectures is to let the upstream CI test your pull request (more on
test your changes on Linux, FreeBSD, macOS and Windows before opening a this below).
pull request.
(See https://docs.travis-ci.com/user/tutorial/ for information
on setting up Travis CI; go to https://ci.appveyor.com/login and log
in with your GitHub account and select "NEW PROJECT" to set up an
AppVeyor build.)
3) Setup your git working copy 3) Setup your git working copy
git clone https://github.com/<username>/tcpdump.git git clone https://github.com/<username>/tcpdump.git
cd tcpdump cd tcpdump
git remote add upstream https://github.com/the-tcpdump-group/tcpdump git remote add upstream https://github.com/the-tcpdump-group/tcpdump
git fetch upstream git fetch upstream
4) Do a 'touch .devel' in your working directory. 4) Do a 'touch .devel' in your working directory.
Currently, the effect is Currently, the effect is
a) add (via configure, in Makefile) some warnings options ( -Wall a) add (via configure, in Makefile) some warnings options ( -Wall
skipping to change at line 107 skipping to change at line 102
7) Test with 'make check' 7) Test with 'make check'
Don't send a pull request if 'make check' gives failed tests. Don't send a pull request if 'make check' gives failed tests.
8) Try to rebase your commits to keep the history simple. 8) Try to rebase your commits to keep the history simple.
git rebase upstream/master git rebase upstream/master
(If the rebase fails and you cannot resolve, issue "git rebase --abort" (If the rebase fails and you cannot resolve, issue "git rebase --abort"
and ask for help in the pull request comment.) and ask for help in the pull request comment.)
9) Once 100% happy, put your work into your forked repository. 9) Once 100% happy, put your work into your forked repository.
git push git push
This will trigger your fork CI tests, if set up in step 2.
10) Initiate and send a pull request 10) Initiate and send a pull request
(See https://help.github.com/articles/using-pull-requests/) (See https://help.github.com/articles/using-pull-requests/)
This will trigger the upstream repository CI tests. This will trigger the upstream repository CI tests.
Code style and generic remarks Code style and generic remarks
------------------------------ ------------------------------
a) A thorough reading of some other printers code is useful. a) A thorough reading of some other printers code is useful.
b) Put the normative reference if any as comments (RFC, etc.). b) Put the normative reference if any as comments (RFC, etc.).
 End of changes. 2 change blocks. 
9 lines changed or deleted 3 lines changed or added

Home  |  About  |  Features  |  All  |  Newest  |  Dox  |  Diffs  |  RSS Feeds  |  Screenshots  |  Comments  |  Imprint  |  Privacy  |  HTTP(S)