is a realtime distributed and and decentralized messaging platform.
| CONTRIBUTING.md (nsq-1.2.0) | : | CONTRIBUTING.md (nsq-1.2.1) |
|---|
| | |
| skipping to change at line 34 | | skipping to change at line 34 |
|---|
| ``` | | ``` |
| nsqd: fixed bug in protocol_v2 | | nsqd: fixed bug in protocol_v2 |
| | |
| * update the message pump to properly account for RDYness | | * update the message pump to properly account for RDYness |
| * cleanup variable names | | * cleanup variable names |
| * ... | | * ... |
| ``` | | ``` |
| | |
| * if you're fixing a bug or adding functionality it probably makes sense to writ
e a test | | * if you're fixing a bug or adding functionality it probably makes sense to writ
e a test |
| * make sure to run `fmt.sh` and `test.sh` in the root of the repo to ensure that
your code is | | * make sure to run `fmt.sh` and `test.sh` in the root of the repo to ensure that
your code is |
|
| properly formatted and that tests pass (NOTE: we integrate Travis with GitHub | | properly formatted and that tests pass (we use GitHub Actions for continuous i |
| for continuous | | ntegration) |
| integration) | | |
| | |
| ## Submitting Changes | | ## Submitting Changes |
| | |
| * push your changes to your branch in your fork of the repository | | * push your changes to your branch in your fork of the repository |
| * submit a pull request against nsqio's repository | | * submit a pull request against nsqio's repository |
| * comment in the pull request when you're ready for the changes to be reviewed:
`"ready for review"` | | * comment in the pull request when you're ready for the changes to be reviewed:
`"ready for review"` |
| | | |
| End of changes. 1 change blocks. |
|---|
| 3 lines changed or deleted | | 2 lines changed or added |
|---|
"Fossies" - the Fresh Open Source Software Archive 