"Fossies" - the Fresh Open Source Software Archive  

Source code changes of the file "CONTRIBUTING" between
haproxy-2.0.13.tar.gz and haproxy-2.0.14.tar.gz

About: HAProxy is a TCP/HTTP reverse proxy which is particularly suited for high availability environments. LTS (Long-Term Support) release.

CONTRIBUTING  (haproxy-2.0.13):CONTRIBUTING  (haproxy-2.0.14)
skipping to change at line 233 skipping to change at line 233
You have read and understood "doc/coding-style.txt", and you're actively You have read and understood "doc/coding-style.txt", and you're actively
determined to respect it and to enforce it on your coworkers if you're going determined to respect it and to enforce it on your coworkers if you're going
to submit a team's work. We don't care what text editor you use, whether it's to submit a team's work. We don't care what text editor you use, whether it's
an hex editor, cat, vi, emacs, Notepad, Word, or even Eclipse. The editor is an hex editor, cat, vi, emacs, Notepad, Word, or even Eclipse. The editor is
only the interface between you and the text file. What matters is what is in only the interface between you and the text file. What matters is what is in
the text file in the end. The editor is not an excuse for submitting poorly the text file in the end. The editor is not an excuse for submitting poorly
indented code, which only proves that the person has no consideration for indented code, which only proves that the person has no consideration for
quality and/or has done it in a hurry (probably worse). Please note that most quality and/or has done it in a hurry (probably worse). Please note that most
bugs were found in low-quality code. Reviewers know this and tend to be much bugs were found in low-quality code. Reviewers know this and tend to be much
more reluctant to accept poorly formated code because by experience they more reluctant to accept poorly formatted code because by experience they
won't trust their author's ability to write correct code. It is also worth won't trust their author's ability to write correct code. It is also worth
noting that poor quality code is painful to read and may result in nobody noting that poor quality code is painful to read and may result in nobody
willing to waste their time even reviewing your work. willing to waste their time even reviewing your work.
4) Present clean work 4) Present clean work
The time it takes for you to polish your code is always much smaller than the The time it takes for you to polish your code is always much smaller than the
time it takes others to do it for you, because they always have to wonder if time it takes others to do it for you, because they always have to wonder if
what they see is intended (meaning they didn't understand something) or if it what they see is intended (meaning they didn't understand something) or if it
is a mistake that needs to be fixed. And since there are less reviewers than is a mistake that needs to be fixed. And since there are less reviewers than
skipping to change at line 984 skipping to change at line 984
more of their time than normally needed with your work anymore. Your best more of their time than normally needed with your work anymore. Your best
option at this point probably is to ask "did I do something wrong" than to option at this point probably is to ask "did I do something wrong" than to
resend the same patches. resend the same patches.
How to be sure to irritate everyone How to be sure to irritate everyone
----------------------------------- -----------------------------------
Among the best ways to quickly lose everyone's respect, there is this small Among the best ways to quickly lose everyone's respect, there is this small
selection, which should help you improve the way you work with others, if selection, which should help you improve the way you work with others, if
you notice you're already practising some of them: you notice you're already practising some of them:
- repeatedly send improperly formated commit messages, with no type or - repeatedly send improperly formatted commit messages, with no type or
severity, or with no commit message body. These ones require manual severity, or with no commit message body. These ones require manual
edition, maintainers will quickly learn to recognize your name. edition, maintainers will quickly learn to recognize your name.
- repeatedly send patches which break something, and disappear or take a long - repeatedly send patches which break something, and disappear or take a long
time to provide a fix. time to provide a fix.
- fail to respond to questions related to features you have contributed in - fail to respond to questions related to features you have contributed in
the past, which can further lead to the feature being declared unmaintained the past, which can further lead to the feature being declared unmaintained
and removed in a future version. and removed in a future version.
 End of changes. 2 change blocks. 
2 lines changed or deleted 2 lines changed or added

Home  |  About  |  Features  |  All  |  Newest  |  Dox  |  Diffs  |  RSS Feeds  |  Screenshots  |  Comments  |  Imprint  |  Privacy  |  HTTP(S)