CONTRIBUTING.md (googletest-release-1.11.0) | : | CONTRIBUTING.md (googletest-release-1.12.0) | ||
---|---|---|---|---|
skipping to change at line 24 | skipping to change at line 24 | |||
* If you work for a company that wants to allow you to contribute your work, | * If you work for a company that wants to allow you to contribute your work, | |||
then you'll need to sign a | then you'll need to sign a | |||
[corporate CLA](https://developers.google.com/open-source/cla/corporate). | [corporate CLA](https://developers.google.com/open-source/cla/corporate). | |||
Follow either of the two links above to access the appropriate CLA and | Follow either of the two links above to access the appropriate CLA and | |||
instructions for how to sign and return it. Once we receive it, we'll be able to | instructions for how to sign and return it. Once we receive it, we'll be able to | |||
accept your pull requests. | accept your pull requests. | |||
## Are you a Googler? | ## Are you a Googler? | |||
If you are a Googler, please make an attempt to submit an internal change rather | If you are a Googler, please make an attempt to submit an internal contribution | |||
than a GitHub Pull Request. If you are not able to submit an internal change a | rather than a GitHub Pull Request. If you are not able to submit internally, a | |||
PR is acceptable as an alternative. | PR is acceptable as an alternative. | |||
## Contributing A Patch | ## Contributing A Patch | |||
1. Submit an issue describing your proposed change to the | 1. Submit an issue describing your proposed change to the | |||
[issue tracker](https://github.com/google/googletest/issues). | [issue tracker](https://github.com/google/googletest/issues). | |||
2. Please don't mix more than one logical change per submittal, because it | 2. Please don't mix more than one logical change per submittal, because it | |||
makes the history hard to follow. If you want to make a change that doesn't | makes the history hard to follow. If you want to make a change that doesn't | |||
have a corresponding issue in the issue tracker, please create one. | have a corresponding issue in the issue tracker, please create one. | |||
3. Also, coordinate with team members that are listed on the issue in question. | 3. Also, coordinate with team members that are listed on the issue in question. | |||
This ensures that work isn't being duplicated and communicating your plan | This ensures that work isn't being duplicated and communicating your plan | |||
early also generally leads to better patches. | early also generally leads to better patches. | |||
4. If your proposed change is accepted, and you haven't already done so, sign a | 4. If your proposed change is accepted, and you haven't already done so, sign a | |||
Contributor License Agreement (see details above). | Contributor License Agreement | |||
([see details above](#contributor-license-agreements)). | ||||
5. Fork the desired repo, develop and test your code changes. | 5. Fork the desired repo, develop and test your code changes. | |||
6. Ensure that your code adheres to the existing style in the sample to which | 6. Ensure that your code adheres to the existing style in the sample to which | |||
you are contributing. | you are contributing. | |||
7. Ensure that your code has an appropriate set of unit tests which all pass. | 7. Ensure that your code has an appropriate set of unit tests which all pass. | |||
8. Submit a pull request. | 8. Submit a pull request. | |||
## The Google Test and Google Mock Communities | ## The Google Test and Google Mock Communities | |||
The Google Test community exists primarily through the | The Google Test community exists primarily through the | |||
[discussion group](http://groups.google.com/group/googletestframework) and the | [discussion group](http://groups.google.com/group/googletestframework) and the | |||
End of changes. 2 change blocks. | ||||
3 lines changed or deleted | 4 lines changed or added |