"Fossies" - the Fresh Open Source Software Archive  

Source code changes of the file "test/ares-test-parse-ptr.cc" between
c-ares-1.17.1.tar.gz and c-ares-1.17.2.tar.gz

About: c-ares is a C library for asynchronous DNS requests (including name resolves).

ares-test-parse-ptr.cc  (c-ares-1.17.1):ares-test-parse-ptr.cc  (c-ares-1.17.2)
skipping to change at line 14 skipping to change at line 14
#include <sstream> #include <sstream>
#include <vector> #include <vector>
namespace ares { namespace ares {
namespace test { namespace test {
TEST_F(LibraryTest, ParsePtrReplyOK) { TEST_F(LibraryTest, ParsePtrReplyOK) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com")); .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com"));
std::vector<byte> data = pkt.data(); std::vector<byte> data = pkt.data();
struct hostent *host = nullptr; struct hostent *host = nullptr;
EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
ASSERT_NE(nullptr, host); ASSERT_NE(nullptr, host);
std::stringstream ss; std::stringstream ss;
ss << HostEnt(host); ss << HostEnt(host);
EXPECT_EQ("{'other.com' aliases=[other.com] addrs=[16.32.48.64]}", ss.str()); EXPECT_EQ("{'other.com' aliases=[other.com] addrs=[16.32.48.64]}", ss.str());
ares_free_hostent(host); ares_free_hostent(host);
} }
TEST_F(LibraryTest, ParsePtrReplyCname) { TEST_F(LibraryTest, ParsePtrReplyCname) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSCnameRR("64.48.32.16.in-addr.arpa", 50, "64.48.32.8.in-ad dr.arpa")) .add_answer(new DNSCnameRR("64.48.32.16.in-addr.arpa", 50, "64.48.32.8.in-ad dr.arpa"))
.add_answer(new DNSPtrRR("64.48.32.8.in-addr.arpa", 100, "other.com")); .add_answer(new DNSPtrRR("64.48.32.8.in-addr.arpa", 100, "other.com"));
std::vector<byte> data = pkt.data(); std::vector<byte> data = pkt.data();
struct hostent *host = nullptr; struct hostent *host = nullptr;
EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
ASSERT_NE(nullptr, host); ASSERT_NE(nullptr, host);
std::stringstream ss; std::stringstream ss;
ss << HostEnt(host); ss << HostEnt(host);
skipping to change at line 65 skipping to change at line 65
PushInt16(&data, len); PushInt16(&data, len);
data.insert(data.end(), encname.begin(), encname.end()); data.insert(data.end(), encname.begin(), encname.end());
return data; return data;
} }
}; };
TEST_F(LibraryTest, ParsePtrReplyMalformedCname) { TEST_F(LibraryTest, ParsePtrReplyMalformedCname) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSMalformedCnameRR("64.48.32.16.in-addr.arpa", 50, "64.48.3 2.8.in-addr.arpa")) .add_answer(new DNSMalformedCnameRR("64.48.32.16.in-addr.arpa", 50, "64.48.3 2.8.in-addr.arpa"))
.add_answer(new DNSPtrRR("64.48.32.8.in-addr.arpa", 100, "other.com")); .add_answer(new DNSPtrRR("64.48.32.8.in-addr.arpa", 100, "other.com"));
std::vector<byte> data = pkt.data(); std::vector<byte> data = pkt.data();
struct hostent *host = nullptr; struct hostent *host = nullptr;
EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
ASSERT_EQ(nullptr, host); ASSERT_EQ(nullptr, host);
} }
TEST_F(LibraryTest, ParseManyPtrReply) { TEST_F(LibraryTest, ParseManyPtrReply) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other4.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other4.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other5.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other5.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other6.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other6.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other7.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other7.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other8.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other8.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other9.com")); .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other9.com"));
skipping to change at line 104 skipping to change at line 104
EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_SUCCESS, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
ASSERT_NE(nullptr, host); ASSERT_NE(nullptr, host);
ares_free_hostent(host); ares_free_hostent(host);
} }
TEST_F(LibraryTest, ParsePtrReplyAdditional) { TEST_F(LibraryTest, ParsePtrReplyAdditional) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 55, "other.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 55, "other.com"))
.add_auth(new DNSNsRR("16.in-addr.arpa", 234, "ns1.other.com")) .add_auth(new DNSNsRR("16.in-addr.arpa", 234, "ns1.other.com"))
.add_auth(new DNSNsRR("16.in-addr.arpa", 234, "bb.ns2.other.com")) .add_auth(new DNSNsRR("16.in-addr.arpa", 234, "bb.ns2.other.com"))
.add_auth(new DNSNsRR("16.in-addr.arpa", 234, "ns3.other.com")) .add_auth(new DNSNsRR("16.in-addr.arpa", 234, "ns3.other.com"))
.add_additional(new DNSARR("ns1.other.com", 229, {10,20,30,41})) .add_additional(new DNSARR("ns1.other.com", 229, {10,20,30,41}))
.add_additional(new DNSARR("bb.ns2.other.com", 229, {10,20,30,42})) .add_additional(new DNSARR("bb.ns2.other.com", 229, {10,20,30,42}))
.add_additional(new DNSARR("ns3.other.com", 229, {10,20,30,43})); .add_additional(new DNSARR("ns3.other.com", 229, {10,20,30,43}));
std::vector<byte> data = pkt.data(); std::vector<byte> data = pkt.data();
struct hostent *host = nullptr; struct hostent *host = nullptr;
skipping to change at line 128 skipping to change at line 128
std::stringstream ss; std::stringstream ss;
ss << HostEnt(host); ss << HostEnt(host);
EXPECT_EQ("{'other.com' aliases=[other.com] addrs=[16.32.48.64]}", ss.str()); EXPECT_EQ("{'other.com' aliases=[other.com] addrs=[16.32.48.64]}", ss.str());
ares_free_hostent(host); ares_free_hostent(host);
} }
TEST_F(LibraryTest, ParsePtrReplyErrors) { TEST_F(LibraryTest, ParsePtrReplyErrors) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com")); .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com"));
std::vector<byte> data; std::vector<byte> data;
struct hostent *host = nullptr; struct hostent *host = nullptr;
// No question. // No question.
pkt.questions_.clear(); pkt.questions_.clear();
data = pkt.data(); data = pkt.data();
EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)); pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR));
// Question != answer // Question != answer
pkt.questions_.clear(); pkt.questions_.clear();
pkt.add_question(new DNSQuestion("99.48.32.16.in-addr.arpa", ns_t_ptr)); pkt.add_question(new DNSQuestion("99.48.32.16.in-addr.arpa", T_PTR));
data = pkt.data(); data = pkt.data();
EXPECT_EQ(ARES_ENODATA, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_ENODATA, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
EXPECT_EQ(nullptr, host); EXPECT_EQ(nullptr, host);
pkt.questions_.clear(); pkt.questions_.clear();
pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)); pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR));
// Two questions. // Two questions.
pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)); pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR));
data = pkt.data(); data = pkt.data();
EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
EXPECT_EQ(nullptr, host); EXPECT_EQ(nullptr, host);
pkt.questions_.clear(); pkt.questions_.clear();
pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)); pkt.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR));
// Wrong sort of answer. // Wrong sort of answer.
pkt.answers_.clear(); pkt.answers_.clear();
pkt.add_answer(new DNSMxRR("example.com", 100, 100, "mx1.example.com")); pkt.add_answer(new DNSMxRR("example.com", 100, 100, "mx1.example.com"));
data = pkt.data(); data = pkt.data();
EXPECT_EQ(ARES_ENODATA, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_ENODATA, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)); addrv4, sizeof(addrv4), AF_INET, &host));
EXPECT_EQ(nullptr, host); EXPECT_EQ(nullptr, host);
pkt.answers_.clear(); pkt.answers_.clear();
pkt.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com")); pkt.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other.com"));
skipping to change at line 199 skipping to change at line 199
EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), len, EXPECT_EQ(ARES_EBADRESP, ares_parse_ptr_reply(data.data(), len,
addrv4, sizeof(addrv4), AF_INE T, &host)); addrv4, sizeof(addrv4), AF_INE T, &host));
EXPECT_EQ(nullptr, host); EXPECT_EQ(nullptr, host);
} }
} }
TEST_F(LibraryTest, ParsePtrReplyAllocFailSome) { TEST_F(LibraryTest, ParsePtrReplyAllocFailSome) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com")); .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com"));
std::vector<byte> data = pkt.data(); std::vector<byte> data = pkt.data();
struct hostent *host = nullptr; struct hostent *host = nullptr;
for (int ii = 1; ii <= 18; ii++) { for (int ii = 1; ii <= 18; ii++) {
ClearFails(); ClearFails();
SetAllocFail(ii); SetAllocFail(ii);
EXPECT_EQ(ARES_ENOMEM, ares_parse_ptr_reply(data.data(), data.size(), EXPECT_EQ(ARES_ENOMEM, ares_parse_ptr_reply(data.data(), data.size(),
addrv4, sizeof(addrv4), AF_INET, &host)) << ii; addrv4, sizeof(addrv4), AF_INET, &host)) << ii;
} }
} }
TEST_F(LibraryTest, ParsePtrReplyAllocFailMany) { TEST_F(LibraryTest, ParsePtrReplyAllocFailMany) {
byte addrv4[4] = {0x10, 0x20, 0x30, 0x40}; byte addrv4[4] = {0x10, 0x20, 0x30, 0x40};
DNSPacket pkt; DNSPacket pkt;
pkt.set_qid(0x1234).set_response().set_aa() pkt.set_qid(0x1234).set_response().set_aa()
.add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", ns_t_ptr)) .add_question(new DNSQuestion("64.48.32.16.in-addr.arpa", T_PTR))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "main.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other1.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other2.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other3.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other4.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other4.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other5.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other5.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other6.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other6.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other7.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other7.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other8.com")) .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other8.com"))
.add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other9.com")); .add_answer(new DNSPtrRR("64.48.32.16.in-addr.arpa", 100, "other9.com"));
 End of changes. 13 change blocks. 
13 lines changed or deleted 13 lines changed or added

Home  |  About  |  Features  |  All  |  Newest  |  Dox  |  Diffs  |  RSS Feeds  |  Screenshots  |  Comments  |  Imprint  |  Privacy  |  HTTP(S)